Skip to content

Commit

Permalink
remove direct approval trigger of E2E suite on PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
Charlie McBride authored and Charlie McBride committed Nov 8, 2023
1 parent af71c81 commit cebd79f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/e2e-matrix-trigger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ on:
workflow_dispatch:
push:
branches: [main]
pull_request_review: # TODO(charliedmcb): come back to this and factor out the E2E trigger like AWS and clean it up
types: [submitted]
workflow_run:
workflows: [ApprovalComment]
types: [completed]
Expand All @@ -13,7 +11,6 @@ permissions:
contents: read # This is required for actions/checkout
jobs:
e2e-matrix:
if: github.event_name != 'pull_request_review' || startsWith(github.event.review.body ,'/test')
uses: ./.github/workflows/e2e-matrix.yaml
secrets:
E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }}
Expand Down

0 comments on commit cebd79f

Please sign in to comment.