Merge pull request #16 from Azure/charliedmcb/turningOffApprovalComme…

…ntTriggerForNow test(e2e): turn off ApprovalComment trigger for now
Azure · Nov 8, 2023 · 9bfdf16 · 9bfdf16
2 parents a1de844 + 4a2ef89
commit 9bfdf16
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/.github/workflows/e2e-matrix-trigger.yaml b/.github/workflows/e2e-matrix-trigger.yaml
@@ -5,17 +5,14 @@ on:
     branches: [main]
   pull_request_review: # TODO(charliedmcb): come back to this and factor out the E2E trigger like AWS and clean it up
     types: [submitted]
-  workflow_run:
-    workflows: [ApprovalComment]
-    types: [completed]
 permissions:
   id-token: write # This is required for requesting the JWT
   contents: read  # This is required for actions/checkout
 jobs:
   e2e-matrix:
-    if: (github.event_name != 'pull_request_review' && github.event_name != 'workflow_run') || (github.event_name == 'pull_request_review' && startsWith(github.event.review.body ,'/test')) || (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success')
+    if: github.event_name != 'pull_request_review' || startsWith(github.event.review.body ,'/test')
     uses: ./.github/workflows/e2e-matrix.yaml
     secrets:
       E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }}
       E2E_TENANT_ID: ${{ secrets.E2E_TENANT_ID }}
-      E2E_SUBSCRIPTION_ID: ${{ secrets.E2E_SUBSCRIPTION_ID }}
+      E2E_SUBSCRIPTION_ID: ${{ secrets.E2E_SUBSCRIPTION_ID }}