Skip to content

Commit

Permalink
update to use approval comment workflow for e2e trigger
Browse files Browse the repository at this point in the history
  • Loading branch information
Charlie McBride authored and Charlie McBride committed Nov 7, 2023
1 parent bee5a16 commit 4a3f2d7
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/approval-comment.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: ApprovalComment
on:
pull_request_review:
types: [submitted]

jobs:
approval-comment:
if: startsWith(github.event.review.body, '/e2e')
runs-on: ubuntu-latest
steps:
- name: run e2e
run: |
echo "run e2e"
6 changes: 3 additions & 3 deletions .github/workflows/e2e-matrix-trigger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ on:
workflow_dispatch:
push:
branches: [main]
pull_request_review: # TODO(charliedmcb): come back to this and factor out the E2E trigger like AWS and clean it up
types: [submitted]
workflow_run:
workflows: [ApprovalComment]
types: [completed]
permissions:
id-token: write # This is required for requesting the JWT
contents: read # This is required for actions/checkout
jobs:
e2e-matrix:
if: github.event_name != 'pull_request_review' || startsWith(github.event.review.body ,'/test')
uses: ./.github/workflows/e2e-matrix.yaml
secrets:
E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }}
Expand Down

0 comments on commit 4a3f2d7

Please sign in to comment.