Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin packages in sdk/python/dev-requirements.txt #2719

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

kdestin
Copy link
Member

@kdestin kdestin commented Oct 9, 2023

Description

pip's version resolver (2020-resolver ?) will sometimes download many versions of a package to find one that satisfies installation constraints. This is usually just incurs a time cost since python packages are usually small, but this was problematic since packages like tensorflow, many nvidia packages, pytorch, etc... are 500MB+.

Pinning known compatible versions prevents pip from doing this search, and stops us from bumping up against the 14GB storage limit in Github Actions.

Checklist

  • I have read the contribution guidelines
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

  pip's version resolver (2020-resolver ?) will sometimes download
  many versions of a package to find one that satisfies installation
  constraints. This is usually just incurs a time cost since python
  packages are usually small, but this was problematic since
  packages like tensorflow, many nvidia packages, pytorch, etc...
  are 500MB+.

  Pinning known compatible versions prevents pip from doing this search,
  and stops us from bumping up against the 14GB storage limit in
  Github Actions.
@kdestin kdestin merged commit 7a74954 into main Oct 9, 2023
105 of 154 checks passed
@kdestin kdestin deleted the kdestin/pin-dev-requirements branch October 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant