This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
Truncate visiblityTimeout when updating QueueMessage #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server will reject requests that do not use an integer value of seconds for visiblity. The AddMessage method already addresses this by using a `long` number of seconds, but UpdateMessage takes a TimeSpan and will include fractional seconds allowing for requests that will always be rejected.
|
Side note - it looks like CONTRIBUTING.md is out of date. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server will reject requests that do not use an integer value of seconds for visiblity. The AddMessage method already addresses this by using a
longnumber of seconds, but UpdateMessage takes a TimeSpan and will include fractional seconds allowing for requests that will always be rejected. This PR addresses the problem by truncating any fractional seconds when creating a Queue request.