Use AzCLI instead of client secret creds #2906
Open
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
gapra-msft
reviewed
Jan 7, 2025
gapra-msft
reviewed
Jan 7, 2025
…into wendi/azcli-auth pull.
…rage-azcopy into wendi/azcli-auth pull.
gapra-msft
reviewed
Jan 7, 2025
gapra-msft
reviewed
Jan 7, 2025
gapra-msft
reviewed
Jan 13, 2025
adreed-msft
reviewed
Jan 14, 2025
| @@ -50,10 +50,8 @@ type NewE2EConfig struct { | |||
| } `env:",required"` | |||
|
|
|||
| StaticStgAcctInfo struct { | |||
| StaticOAuth struct { | |||
There was a problem hiding this comment.
nit: this could be done as an either/or setup
weigh this with a grain of salt, most of the team will probably do inherited auth
There was a problem hiding this comment.
on a similar note, could it be set up to allow AzCLI or AzPwsh inheritance? Some people on the team use one or the other, not usually both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
NEW_E2E_STATIC_CLIENT_SECRET.Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!