chore(playwrighttesting): update public classes, methods and constants as per APIView review #47652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Sid200026
commented
Dec 24, 2024
Sid200026
commented
- Usage of ILogger provided by Microsoft.Extensions.Logging
- Usage of Extensible Enums
- Refactor class constructors
- Sync and async methods for Initialize
- Convert TestReportingClientOptions to internal class
- Renamed Os to OS
added 6 commits
December 23, 2024 11:28
Sid200026
requested review from
JoshLove-msft,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft,
jsquire,
m-nash,
ArthurMa1978,
puagarwa and
ShreyaAnand
as code owners
Sid200026
commented
Dec 24, 2024
| @@ -192,6 +192,7 @@ | |||
| <ItemGroup Condition="$(MSBuildProjectName.StartsWith('Azure.Developer.MicrosoftPlaywrightTesting'))"> | |||
| <PackageReference Update="Microsoft.TestPlatform.ObjectModel" Version="17.10.0" /> | |||
| <PackageReference Update="NUnit" Version="3.13.2" /> | |||
| <PackageReference Update="Microsoft.Extensions.Logging" Version="2.0.0" /> | |||
There was a problem hiding this comment.
This was added as per recommendation in APIView review to use Microsoft.Extensions.Logging's ILogger interface. Added the dependency under this condition since it's used only in Extension libraries.
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Developer.MicrosoftPlaywrightTesting.NUnit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.