Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignalR functions bindings] Self-implemented MessagePack hub protocol #47649

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Dec 24, 2024

As Microsoft.AspNetCore.SignalR.Protocols.MessagePack 1.x relies on an unsecure MessagePack version 1.x, and we cannot update Microsoft.AspNetCore.SignalR.Protocols.MessagePack to 2.x as we have to support .NET Standard 2.0 framework, we implement the required functionalities of Microsoft.AspNetCore.SignalR.Protocols.MessagePack with MessagePack 2.0

This pull request includes several updates and improvements to the Microsoft.Azure.WebJobs.Extensions.SignalRService package, including dependency updates, breaking changes, and new internal implementations for MessagePack protocol support.

Dependency updates:

  • Updated MessagePack to version 2.5.192 and Microsoft.Azure.SignalR packages to version 1.29.0 in eng/Packages.Data.props and CHANGELOG.md files. [1] [2]

Breaking changes:

  • Removed .NET 6.0 support from Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj. [1] [2]

New internal implementations for MessagePack protocol:

  • Added BinaryMessageFormatter, DefaultMessagePackHubProtocolWorker, MessagePackHubProtocol, and MessagePackHubProtocolWorker classes to support MessagePack serialization and deserialization. [1] [2] [3] [4]

Code improvements:

  • Added JTokenWrapperMessagePackFormatter to JTokenWrapper class for MessagePack serialization support. [1] [2]

Test updates:

  • Updated test cases to use MicrosoftEntraAccessKey instead of AadAccessKey and added validation for issuer and audience in DefaultSecurityTokenValidatorTests. [1] [2] [3]
Details

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Azure.WebJobs.Extensions.SignalRService

@Y-Sindo Y-Sindo force-pushed the messagePackHubProtocol branch from 0047da9 to b36866f Compare January 8, 2025 05:26
@Y-Sindo Y-Sindo changed the title [SignalR functions bindings] Self-implemented MessagePackhubprotocol [SignalR functions bindings] Self-implemented MessagePack hub protocol Jan 8, 2025
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package bumps look good.

@Y-Sindo Y-Sindo merged commit 0fa8d45 into Azure:main Jan 9, 2025
51 checks passed
@Y-Sindo Y-Sindo deleted the messagePackHubProtocol branch January 9, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants