[SignalR functions bindings] Self-implemented MessagePack hub protocol #47649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Microsoft.AspNetCore.SignalR.Protocols.MessagePack
1.x relies on an unsecureMessagePack
version 1.x, and we cannot updateMicrosoft.AspNetCore.SignalR.Protocols.MessagePack
to 2.x as we have to support .NET Standard 2.0 framework, we implement the required functionalities ofMicrosoft.AspNetCore.SignalR.Protocols.MessagePack
withMessagePack
2.0MessagePackHubProtocol
files from https://github.com/dotnet/aspnetcore/blob/0825def633c99d9fdd74e47e69bcde3935a5fe74/This pull request includes several updates and improvements to the
Microsoft.Azure.WebJobs.Extensions.SignalRService
package, including dependency updates, breaking changes, and new internal implementations for MessagePack protocol support.Dependency updates:
MessagePack
to version 2.5.192 andMicrosoft.Azure.SignalR
packages to version 1.29.0 ineng/Packages.Data.props
andCHANGELOG.md
files. [1] [2]Breaking changes:
Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj
. [1] [2]New internal implementations for MessagePack protocol:
BinaryMessageFormatter
,DefaultMessagePackHubProtocolWorker
,MessagePackHubProtocol
, andMessagePackHubProtocolWorker
classes to support MessagePack serialization and deserialization. [1] [2] [3] [4]Code improvements:
JTokenWrapperMessagePackFormatter
toJTokenWrapper
class for MessagePack serialization support. [1] [2]Test updates:
MicrosoftEntraAccessKey
instead ofAadAccessKey
and added validation for issuer and audience inDefaultSecurityTokenValidatorTests
. [1] [2] [3]Details