Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS][Common] OPS - Added Routing Logic Based on Scopes #47609

Conversation

AikoBB
Copy link
Member

@AikoBB AikoBB commented Dec 18, 2024

Contributing to the Azure SDK

  • Modified the EntraTokenCredential class to route requests to the appropriate endpoint based on the provided scopes
  • Added unit tests to verify the new routing logic and ensure its correctness.
  • Updated the md files to reflect the changes

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Communication.Common

@AikoBB AikoBB requested a review from DominikMe December 18, 2024 16:06
Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One outstanding comment on the test cases, otherwise looks really good!

@AikoBB AikoBB merged commit ede6c70 into Azure:feature/communication/entra-identity Dec 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants