-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS][Common] OPS - Added Routing Logic Based on Scopes #47609
Merged
AikoBB
merged 4 commits into
Azure:feature/communication/entra-identity
from
AikoBB:feature/aigerimb/ops_new_endpoint
Dec 31, 2024
Merged
[ACS][Common] OPS - Added Routing Logic Based on Scopes #47609
AikoBB
merged 4 commits into
Azure:feature/communication/entra-identity
from
AikoBB:feature/aigerimb/ops_new_endpoint
Dec 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AikoBB
requested review from
maximrytych-ms and
mjafferi-msft
as code owners
December 18, 2024 14:25
API change check APIView has identified API level changes in this PR and created following API reviews. |
DominikMe
reviewed
Dec 18, 2024
DominikMe
reviewed
Dec 18, 2024
DominikMe
reviewed
Dec 18, 2024
sdk/communication/Azure.Communication.Common/src/EntraCommunicationTokenCredentialOptions.cs
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Dec 18, 2024
sdk/communication/Azure.Communication.Common/src/EntraTokenCredential.cs
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Dec 18, 2024
sdk/communication/Azure.Communication.Common/src/EntraTokenCredential.cs
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Dec 18, 2024
sdk/communication/Azure.Communication.Common/src/EntraTokenCredential.cs
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Dec 18, 2024
sdk/communication/Azure.Communication.Common/src/EntraTokenCredential.cs
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Dec 18, 2024
sdk/communication/Azure.Communication.Common/tests/Identity/EntraTokenCredentialTest.cs
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Dec 19, 2024
sdk/communication/Azure.Communication.Common/tests/Identity/EntraTokenCredentialTest.cs
Outdated
Show resolved
Hide resolved
DominikMe
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One outstanding comment on the test cases, otherwise looks really good!
AikoBB
merged commit Dec 31, 2024
ede6c70
into
Azure:feature/communication/entra-identity
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
EntraTokenCredential
class to route requests to the appropriate endpoint based on the provided scopesPlease see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.