Add mock test cases for CAE auth in mgmt client #32351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
MaryGao
commented
Dec 24, 2024
MaryGao
commented
Dec 24, 2024
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
Dec 30, 2024
qiaozha
reviewed
Jan 8, 2025
| describe("Mock test for CAE with ResourceManagementClient", () => { | ||
| // this is not a real token, does not contain any sensitive info, just for test. | ||
| const caeChallenge = `Bearer realm="", error_description="Continuous access evaluation resulted in challenge", error="insufficient_claims", claims="eyJhY2Nlc3NfdG9rZW4iOnsibmJmIjp7ImVzc2VudGlhbCI6dHJ1ZSwgInZhbHVlIjoiMTcyNjI1ODEyMiJ9fX0=" `; | ||
| const invalidCAEChallenge = `Bearer realm="", error_description="", error="insufficient_claims", claims=""`; |
There was a problem hiding this comment.
just curious what decides if the caeChallenge is valid or not? maybe we should add some description for it?
There was a problem hiding this comment.
Added a comment for that: regarding CAE challenge string you could refer the link https://learn.microsoft.com/entra/identity-platform/claims-challenge.
Our code implementation is aligned with that doc: https://github.com/azure/azure-sdk-for-js/blob/main/sdk/core/core-rest-pipeline/src/policies/bearerTokenAuthenticationPolicy.ts#L375.
MaryGao
commented
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31754