Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Javadoc of premium SDK for azure-resourcemanager-dns #43529

Closed
wants to merge 2 commits into from
Closed

Update Javadoc of premium SDK for azure-resourcemanager-dns #43529

wants to merge 2 commits into from

Conversation

v-hongli1
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 23, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 23, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@v-hongli1 v-hongli1 marked this pull request as ready for review December 23, 2024 06:16
weidongxu-microsoft
weidongxu-microsoft reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this PR have change on containerservice ?

@v-hongli1 v-hongli1 closed this Dec 25, 2024
@v-hongli1 v-hongli1 deleted the update-Javadoc-of-premium-SDK-dns branch December 25, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-hongli1 @azure-sdk @weidongxu-microsoft