-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options to fine-tune settings for bulk operations #43509
base: main
Are you sure you want to change the base?
Added options to fine-tune settings for bulk operations #43509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosConfig.scala: Language not supported
- sdk/cosmos/azure-cosmos-spark_3_2-12/src/test/scala/com/azure/cosmos/spark/SparkE2EWriteITest.scala: Language not supported
Comments suppressed due to low confidence (1)
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/batch/PartitionScopeThresholdsTest.java:44
- Corrected the method name from 'alwaysThrottledShouldResultInBatSizeOfOne' to 'alwaysThrottledShouldResultInBatchSizeOfOne'.
public void alwaysThrottledShouldResultInBatchSizeOfOne() {
API change check API changes are not detected in this pull request. |
minTargetBulkBatchSize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - except 1 question.
...ure-cosmos/src/main/java/com/azure/cosmos/implementation/batch/PartitionScopeThresholds.java
Show resolved
Hide resolved
/azp run java - cosmos - spark |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This PR allows fine-tuning some setting for bulk ingestion
spark.cosmos.write.bulk.minTargetBatchSize
can be used to override the minimum target batch size (the target batch isze is calculated based on throttling rate and by default can be reduced to 1 - this setting allows increasing the minimum traget batch size).COSMOS.MIN_TARGET_BULK_MICRO_BATCH_SIZE
/Environment variableCOSMOS_MIN_TARGET_BULK_MICRO_BATCH_SIZE
COSMOS.MAX_BULK_MICRO_BATCH_CONCURRENCY
/Environment variableCOSMOS_MAX_BULK_MICRO_BATCH_CONCURRENCY
COSMOS.MAX_BULK_MICRO_BATCH_FLUSH_INTERVAL_IN_MILLISECONDS
/Environment variableCOSMOS_MAX_BULK_MICRO_BATCH_FLUSH_INTERVAL_IN_MILLISECONDS
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines