Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Simplify service client builders #43464

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Simplify service client builders #43464

wants to merge 1 commit into from

Conversation

alzimmermsft
Copy link
Member

Description

Prototype where a few changes are being made to simplify service client builder logic.

  • HttpTrait hides more complex configuration options behind a nested callback API modifyBuilder(Consumer<HttpPipelineBuilder>).
  • HttpClientBuilderBase<T> is introduced to manage HttpPipeline creation for all HTTP-based service client builders.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity Awaiting requested review from samvaity samvaity will be requested when the pull request is marked ready for review samvaity is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 will be requested when the pull request is marked ready for review vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar will be requested when the pull request is marked ready for review srnagar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
clientcore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alzimmermsft