-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compile-time annotation-processor tool to clientcore #43457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...re/tools/sdk-codegen-tool/src/main/java/io/generation/tools/codegen/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
compile-time-codegen
branch
from
December 19, 2024 22:45
cadcf9b
to
149a750
Compare
samvaity
changed the title
Add compile time sdk-codegen-tool
Add Compile-time annotation-processor tool to clientcore
Dec 19, 2024
joshfree
approved these changes
Dec 20, 2024
...ools/annotation-processor/src/main/java/io/clientcore/tools/codegen/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...ools/annotation-processor/src/main/java/io/clientcore/tools/codegen/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...ools/annotation-processor/src/main/java/io/clientcore/tools/codegen/AnnotationProcessor.java
Show resolved
Hide resolved
...ools/annotation-processor/src/main/java/io/clientcore/tools/codegen/AnnotationProcessor.java
Show resolved
Hide resolved
...ools/annotation-processor/src/main/java/io/clientcore/tools/codegen/AnnotationProcessor.java
Show resolved
Hide resolved
.../tools/annotation-processor/src/main/java/io/clientcore/tools/codegen/utils/PathBuilder.java
Show resolved
Hide resolved
.../tools/annotation-processor/src/main/java/io/clientcore/tools/codegen/utils/PathBuilder.java
Show resolved
Hide resolved
.../tools/annotation-processor/src/main/java/io/clientcore/tools/codegen/utils/PathBuilder.java
Outdated
Show resolved
Hide resolved
.../tools/annotation-processor/src/main/java/io/clientcore/tools/codegen/utils/PathBuilder.java
Outdated
Show resolved
Hide resolved
.../tools/annotation-processor/src/main/java/io/clientcore/tools/codegen/utils/PathBuilder.java
Outdated
Show resolved
Hide resolved
samvaity
requested review from
g2vinay,
rujche,
Netyyyy,
saragluna,
moarychan,
hallipr,
weshaggard,
benbp,
JimSuplizio,
srnagar,
conniey and
vcolin7
as code owners
January 7, 2025 23:18
alzimmermsft
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving even though further review could be done as unblocking this to begin generating SDKs with this is more important and will find more issues than code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new
/sdk/clientcore/tools
package named annotation-processor, which serves as a shippable replacement for the in-house RestProxy annotation processing utilities used to generate HTTP client service implementations.This package addresses common challenges with service client implementations relying on the intermediate RestProxy layer, which introduces reflection-based inefficiencies, negatively impacts performance, and produces less readable stack traces. Instead, annotation-processor uses JavaPoet to process annotations and generate service client implementations. Currently, it generates the respective service client implementation in
${project.build.directory}/generated-sources/
.Remaining Work:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines