Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update properties description according to current doc #43447

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update properties description according to current doc #43447

wants to merge 12 commits into from

Conversation

v-minh1
Copy link

@v-minh1 v-minh1 commented Dec 17, 2024 •
edited
Loading

Description

  1. Update properties description according to current doc.
  2. Fix String duplication issue.
    image
    image

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added azure-spring All azure-spring related issues Azure.Core azure-core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. labels Dec 17, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @v-minh1! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@v-minh1
Copy link
Author

v-minh1 commented Dec 17, 2024

@microsoft-github-policy-service agree company="Microsoft"

@alzimmermsft alzimmermsft removed Azure.Core azure-core Mgmt This issue is related to a management-plane library. labels Dec 17, 2024
@saragluna saragluna changed the title Ipdate properties description according to current doc Update properties description according to current doc Dec 18, 2024
v-minh1 and others added 3 commits December 24, 2024 14:03
@v-minh1
implement this in the doc plugin, we can replace '' in the comment to…
60323f5 
… , so revert these changes.
@v-minh1
Implement this in the doc plugin, we can replace '' in the comment to…
af99df7 
… ``, so revert these changes.Merge branch 'main' of github.com:v-minh1/azure-sdk-for-java
@v-minh1
Merge branch 'Azure:main' into main
2de7372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@saragluna saragluna saragluna requested changes

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@srnagar srnagar Awaiting requested review from srnagar

@anuchandy anuchandy Awaiting requested review from anuchandy

@lmolkova lmolkova Awaiting requested review from lmolkova

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@mssfang mssfang Awaiting requested review from mssfang

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@billwert billwert Awaiting requested review from billwert

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@v-minh1 @azure-sdk @saragluna @weidongxu-microsoft @Netyyyy @alzimmermsft