Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to azure-core-version-tests #35401

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Jun 9, 2023

Description

Fixes #35399

Adds more test cases to azure-core-version-tests for further version support validation.

This PR also fixes a behavioral change in parsing of XML String arrays where empty and self-closing tags were treated as empty string and then changed to null. A deserialization modifier was added to coerce null back to empty string.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core MQ-Testing Testing milestone quality labels Jun 9, 2023
@alzimmermsft alzimmermsft self-assigned this Jun 9, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alzimmermsft alzimmermsft merged commit d3710fd into Azure:main Jun 9, 2023
@alzimmermsft alzimmermsft deleted the AzCore_EnhanceJacksonVersionTesting branch June 9, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. MQ-Testing Testing milestone quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Support new version of 'jackson-dataformat-xml'
3 participants