Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.DeviceRegistry] - Integrate Azure Device Registry APIs into Azure Powershell Commandlets for version 2024-11-01 #26914

Open
wants to merge 5 commits into
base: generation
Choose a base branch
from

Conversation

mryanlo
Copy link

@mryanlo mryanlo commented Dec 21, 2024

Description

This PR integrates the Azure Device Registry APIs into the Azure Powershell Commandlets. I followed the instructions from the autorest autogenerating pwsh guide here. This exposes the GA API version 2024-11-01 of ADRs ARM specs to make them available to call via powershell commandlets.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

## SYNTAX

```
Get-AzDeviceRegistryOperationStatus -Location <String> -OperationId <String> [-SubscriptionId <String[]>]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Current pwsh commandlets for Create/Update resources automatically wait for async operation status to complete, as well as this pwsh command cannot get the async op uri signing params (see here to successfully run

@mryanlo mryanlo marked this pull request as ready for review December 23, 2024 23:43
@VeryEarly VeryEarly self-assigned this Dec 24, 2024
remove: true
# Remove GetViaIdentity and GetViaIdentityLocation from the Get-AzDeviceRegistryOperationStatus
- where:
variant: ^GetViaIdentity$|GetViaIdentityLocation$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line so all operationsstatus related cmdlets will be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants