Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VirtualRouterAutoScaleConfiguration for Route Server #26908

Merged

Conversation

ksteinmeyer2023
Copy link
Contributor

@ksteinmeyer2023 ksteinmeyer2023 commented Dec 20, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Dec 20, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Batch
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.CognitiveServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ContainerRegistry
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.DataLakeStore
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Dns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 22.09 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.
️✔️Az.Maintenance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.39 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 75.00 % 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 62.15 % 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@VeryEarly
Copy link
Contributor

please add changelog:
image

@VeryEarly VeryEarly self-assigned this Dec 20, 2024
@ksteinmeyer2023 ksteinmeyer2023 changed the title starting changes for ars autoscale Adding VirtualRouterAutoScaleConfiguration for Route Server Jan 6, 2025
@YanaXu YanaXu assigned YanaXu and unassigned VeryEarly Jan 8, 2025
@YanaXu
Copy link
Contributor

YanaXu commented Jan 8, 2025

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@YanaXu YanaXu added the Network label Jan 8, 2025
@YanaXu
Copy link
Contributor

YanaXu commented Jan 8, 2025

Hi @ksteinmeyer2023 , please check the checkbox in the PR description. Since it's to main branch, I think it's for "General release".
image

@YanaXu YanaXu merged commit d7173ff into Azure:main Jan 8, 2025
13 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
* starting changes for ars autoscale

* update, get, and create work

* saving test progress

* updating help docs

* UT is recorded

* addressing PR comments

* updating the session record

---------

Co-authored-by: Yan Xu <[email protected]>
VeryEarly added a commit that referenced this pull request Jan 9, 2025
* Update private-link-resource-example.md (#26972)

* Remove SSL errors check. (#26973)

* Start-AzAutomationRunbook Object ref error (#26924)

* Start-AzAutomationRunbook Object ref error

* Update ChangeLog.md

---------

Co-authored-by: Divyesh Govaerdhanan <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>

* Fix json format issue (#26978)

* Add Managed Identity Support in Azure Disk Encryption (#26652)

* Changes

* Add UT's

* Unwanted changes

* Update markdown file

* Modified code and handle comments

* Update comments and removed unwanted code

* update test case

* fix comments

* fix changelog

* Addressed comments

* fix changes

* Removed unwanted changes

* Throw exception when encryption identity is not part of assigned Identities

* Remove unwanted changes

* Remove changes not required

* remove unwanted changes1

* fix remaining unwanted changes

* fix identation issues

* markdown check

---------

Co-authored-by: Anshul Jain <[email protected]>

* Adding VirtualRouterAutoScaleConfiguration for Route Server (#26908)

* starting changes for ars autoscale

* update, get, and create work

* saving test progress

* updating help docs

* UT is recorded

* addressing PR comments

* updating the session record

---------

Co-authored-by: Yan Xu <[email protected]>

* comment out ApiManagementHelper.cs (#26989)

* Update ApiManagementHelper.cs

* Update resource manager namespace imports

* Comment out unused code in ApiManagementHelper.cs

* Update ApiManagementTests.cs

---------

Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: Divyesh Govardhanan <[email protected]>
Co-authored-by: Divyesh Govaerdhanan <[email protected]>
Co-authored-by: Anshul Jain <[email protected]>
Co-authored-by: Anshul Jain <[email protected]>
Co-authored-by: ksteinmeyer2023 <[email protected]>
Co-authored-by: Yan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants