-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding VirtualRouterAutoScaleConfiguration for Route Server #26908
Merged
YanaXu
merged 8 commits into
Azure:main
from
ksteinmeyer2023:addingControlPlaneScalingForRouteServer
Jan 8, 2025
Merged
Adding VirtualRouterAutoScaleConfiguration for Route Server #26908
YanaXu
merged 8 commits into
Azure:main
from
ksteinmeyer2023:addingControlPlaneScalingForRouteServer
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
|
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
Type | Title | Current Coverage | Description |
---|---|---|---|
Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.Maintenance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00 % 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName.
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 1 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 2 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 3 1 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname. ⚠️ Update-AzRouteServer 4 2 Unassigned_Variable Update-AzRouteServer -RouteServerName $routeServerName is a null-valued parameter value. -RouteServerName Assign value for $routeServerName. ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15 % 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
ksteinmeyer2023
changed the title
starting changes for ars autoscale
Adding VirtualRouterAutoScaleConfiguration for Route Server
Jan 6, 2025
VeryEarly
reviewed
Jan 7, 2025
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
YanaXu
approved these changes
Jan 8, 2025
Hi @ksteinmeyer2023 , please check the checkbox in the PR description. Since it's to main branch, I think it's for "General release". |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
* starting changes for ars autoscale * update, get, and create work * saving test progress * updating help docs * UT is recorded * addressing PR comments * updating the session record --------- Co-authored-by: Yan Xu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Jan 9, 2025
* Update private-link-resource-example.md (#26972) * Remove SSL errors check. (#26973) * Start-AzAutomationRunbook Object ref error (#26924) * Start-AzAutomationRunbook Object ref error * Update ChangeLog.md --------- Co-authored-by: Divyesh Govaerdhanan <[email protected]> Co-authored-by: Yabo Hu <[email protected]> * Fix json format issue (#26978) * Add Managed Identity Support in Azure Disk Encryption (#26652) * Changes * Add UT's * Unwanted changes * Update markdown file * Modified code and handle comments * Update comments and removed unwanted code * update test case * fix comments * fix changelog * Addressed comments * fix changes * Removed unwanted changes * Throw exception when encryption identity is not part of assigned Identities * Remove unwanted changes * Remove changes not required * remove unwanted changes1 * fix remaining unwanted changes * fix identation issues * markdown check --------- Co-authored-by: Anshul Jain <[email protected]> * Adding VirtualRouterAutoScaleConfiguration for Route Server (#26908) * starting changes for ars autoscale * update, get, and create work * saving test progress * updating help docs * UT is recorded * addressing PR comments * updating the session record --------- Co-authored-by: Yan Xu <[email protected]> * comment out ApiManagementHelper.cs (#26989) * Update ApiManagementHelper.cs * Update resource manager namespace imports * Comment out unused code in ApiManagementHelper.cs * Update ApiManagementTests.cs --------- Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Divyesh Govardhanan <[email protected]> Co-authored-by: Divyesh Govaerdhanan <[email protected]> Co-authored-by: Anshul Jain <[email protected]> Co-authored-by: Anshul Jain <[email protected]> Co-authored-by: ksteinmeyer2023 <[email protected]> Co-authored-by: Yan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.