[Compute] Bug fix in Invoke-AzVMPatchAssessment #25714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haagha
requested review from
bilaakpan-ms,
Sandido and
grizzlytheodore
as code owners
️✔️Az.Accounts
❌Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Security
️✔️Az.Sql
️✔️Az.Ssh
️✔️Az.Storage
|
Sandido
requested changes
Aug 9, 2024
| @@ -29,7 +29,7 @@ public class PSVirtualMachinePatchAssessmentResult | |||
| public int? CriticalAndSecurityPatchCount { get; set; } | |||
| public int? OtherPatchCount { get; set; } | |||
| public DateTime? StartDateTime { get; set; } | |||
| public IList<VirtualMachineSoftwarePatchProperties> Patches { get; set; } | |||
| public IList<VirtualMachineSoftwarePatchProperties> AvailablePatches { get; private set; } | |||
There was a problem hiding this comment.
So the issue was that the PS object made up a nonexistent Patches property instead of the AvailablePatches property which actually exists on the VirtualMachineAssessPatchesResult.cs object?
| @@ -29,7 +29,7 @@ public class PSVirtualMachinePatchAssessmentResult | |||
| public int? CriticalAndSecurityPatchCount { get; set; } | |||
| public int? OtherPatchCount { get; set; } | |||
| public DateTime? StartDateTime { get; set; } | |||
| public IList<VirtualMachineSoftwarePatchProperties> Patches { get; set; } | |||
| public IList<VirtualMachineSoftwarePatchProperties> AvailablePatches { get; private set; } | |||
| public ApiError Error { get; set; } | |||
There was a problem hiding this comment.
Please write a test for this as the initial functionality seems to have never been tested as this issue would have been caught back then.
Sandido
requested changes
Aug 9, 2024
| @@ -29,7 +29,7 @@ public class PSVirtualMachinePatchAssessmentResult | |||
| public int? CriticalAndSecurityPatchCount { get; set; } | |||
| public int? OtherPatchCount { get; set; } | |||
| public DateTime? StartDateTime { get; set; } | |||
There was a problem hiding this comment.
you need to add a breaking change suppression to this file:
tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv
and add a description to this PR describing why you need to do this and it is not really a breaking change.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #25123
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.