Update Azure.Identity to 1.4 and MSAL lib to 4.30.1 #14977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
previously approved these changes
May 13, 2021
| { | ||
| //There's no official error message for requiring MFA permission, so have to compare UGLY error message | ||
| if(msalUiRequiredException.ErrorCode == "invalid_grant" && | ||
| msalUiRequiredException.Message.Contains("you must use multi-factor authentication to access")) |
There was a problem hiding this comment.
Is it possible the error message is localized into other languages that this assertion will fail?
Can we use the error code "AADSTS50076" to identify this kind of error instead?
There was a problem hiding this comment.
Neither error message nor error code should be used to determine if interactive authentication should be invoked. See the discussion at AzureAD/microsoft-authentication-library-for-python#701.
isra-fel
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Azure.Identity and MSAL lib to latest official version including token cache refactoring
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added