-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI refresh for dynatrace #8201
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_add |
||
dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_force_string |
||
dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_remove |
||
dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_set |
||
dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter no_wait |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
self.TagRulesUpdate(ctx=self.ctx)() | ||
self.TagRulesGet(ctx=self.ctx)() | ||
self.pre_instance_update(self.ctx.vars.instance) | ||
self.InstanceUpdateByJson(ctx=self.ctx)() | ||
self.InstanceUpdateByGeneric(ctx=self.ctx)() | ||
self.post_instance_update(self.ctx.vars.instance) | ||
yield self.TagRulesCreateOrUpdate(ctx=self.ctx)() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update changed from Patch
to Get+Put
. Is it by design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
We don't have Patch call for tag rules. We had to provide update CLI command so it design decision was made previously.
[Release] Update index.json for extension [ dynatrace ] : https://dev.azure.com/azclitools/release/_build/results?buildId=201278&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.