CLI refresh for dynatrace #8201
Merged
+512
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_add |
||
| dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_force_string |
||
| dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_remove |
||
| dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter generic_update_set |
||
| dynatrace monitor tag-rule update | cmd dynatrace monitor tag-rule update added parameter no_wait |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
kairu-ms
reviewed
Oct 28, 2024
Comment on lines
-146
to
+176
| self.TagRulesUpdate(ctx=self.ctx)() | ||
| self.TagRulesGet(ctx=self.ctx)() | ||
| self.pre_instance_update(self.ctx.vars.instance) | ||
| self.InstanceUpdateByJson(ctx=self.ctx)() | ||
| self.InstanceUpdateByGeneric(ctx=self.ctx)() | ||
| self.post_instance_update(self.ctx.vars.instance) | ||
| yield self.TagRulesCreateOrUpdate(ctx=self.ctx)() |
There was a problem hiding this comment.
The update changed from Patch to Get+Put. Is it by design?
There was a problem hiding this comment.
Yes.
We don't have Patch call for tag rules. We had to provide update CLI command so it design decision was made previously.
kairu-ms
approved these changes
Oct 28, 2024
|
[Release] Update index.json for extension [ dynatrace ] : https://dev.azure.com/azclitools/release/_build/results?buildId=201278&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.