Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s-configuration] Update extension CLI to v2.1.0 #8184

Merged

Conversation

bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 23, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️k8s-configuration
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd k8s-configuration flux kustomization create cmd k8s-configuration flux kustomization create added parameter disable_health_check
⚠️ 1006 - ParaAdd k8s-configuration flux kustomization update cmd k8s-configuration flux kustomization update added parameter disable_health_check

Copy link

Hi @bavneetsingh16,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 23, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

@zhoxing-ms
Copy link
Contributor

Could you please add some test cases for this new feature?

@bavneetsingh16
Copy link
Contributor Author

Could you please add some test cases for this new feature?

We have set up live tests in our forked repository as a continuous integration (CI) check and have included tests for this new parameter. All the tests in the file linked below pertain to the changes in this pull request:
https://github.com/AzureArcForKubernetes/k8s-configuration/blob/main/testing/test/configurations/FluxKustomization.Wait.Tests.ps1

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

@zhoxing-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bavneetsingh16
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8184 in repo Azure/azure-cli-extensions

@zhoxing-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 0fef03f into Azure:main Oct 24, 2024
31 of 32 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ k8s-configuration ] : https://dev.azure.com/azclitools/release/_build/results?buildId=200214&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants