-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s-configuration] Update extension CLI to v2.1.0 #8184
[k8s-configuration] Update extension CLI to v2.1.0 #8184
Conversation
create test pipeline for k8s-configuration cli extension
…into upstream_changes
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
k8s-configuration flux kustomization create | cmd k8s-configuration flux kustomization create added parameter disable_health_check |
||
k8s-configuration flux kustomization update | cmd k8s-configuration flux kustomization update added parameter disable_health_check |
Hi @bavneetsingh16, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Could you please add some test cases for this new feature? |
Co-authored-by: Xing Zhou <[email protected]>
We have set up live tests in our forked repository as a continuous integration (CI) check and have included tests for this new parameter. All the tests in the file linked below pertain to the changes in this pull request: As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 8184 in repo Azure/azure-cli-extensions |
…AzureArcForKubernetes/k8s-configuration into k8s-configuration/release-2.1.0
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
[Release] Update index.json for extension [ k8s-configuration ] : https://dev.azure.com/azclitools/release/_build/results?buildId=200214&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.