Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/az aks nodepool add: No longer supports creating nodepools with ossku CBLMariner #7871

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Aug 9, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

[AKS] az aks create/az aks nodepool add: No longer supports creating nodepools with ossku CBLMariner. See #29699.

Related command

  • az aks create
  • az aks nodepool add

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 9, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1010 - ParaPropUpdate aks create cmd aks create update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu'] to ['AzureLinux', 'Mariner', 'Ubuntu']
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Windows2019', 'Windows2022', 'WindowsAnnual'] to ['AzureLinux', 'Mariner', 'Ubuntu', 'Windows2019', 'Windows2022', 'WindowsAnnual']

Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 9, 2024

AKS

Copy link

github-actions bot commented Aug 9, 2024

⚠️ Release Suggestions

Module: aks-preview

  • Update VERSION to 7.0.0b5 in src/aks-preview/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants