better if check for making pub ip in create

Azure · Oct 18, 2024 · f94e82b · f94e82b
1 parent 8a902a6
commit f94e82b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/vm-repair/azext_vm_repair/custom.py b/src/vm-repair/azext_vm_repair/custom.py
@@ -99,7 +99,7 @@ def create(cmd, vm_name, resource_group_name, repair_password=None, repair_usern
             os_type = 'Windows'
 
         # Set public IP address for repair VM
-        public_ip_name = _make_public_ip_name(repair_vm_name, associate_public_ip, yes)
+        public_ip_name = _make_public_ip_name(repair_vm_name, associate_public_ip)
 
         # Set up base create vm command
         if is_linux:
@@ -352,7 +352,8 @@ def restore(cmd, vm_name, resource_group_name, disk_name=None, repair_vm_id=None
             repair_vm_id = parse_resource_id(repair_vm_id)
             repair_vm_name = repair_vm_id['name']
             repair_resource_group = repair_vm_id['resource_group']
-
+        source_disk = None
+
         # MANAGED DISK
         if is_managed:
             source_disk = source_vm.storage_profile.os_disk.name

diff --git a/src/vm-repair/azext_vm_repair/repair_utils.py b/src/vm-repair/azext_vm_repair/repair_utils.py
@@ -800,8 +800,8 @@ def _fetch_osdisk_security_profile_parameters(source_vm):
     return create_repair_vm_command
 
 
-def _make_public_ip_name(repair_vm_name, associate_public_ip, yes_pub_ip):
+def _make_public_ip_name(repair_vm_name, associate_public_ip):
     public_ip_name = '""'
-    if associate_public_ip or yes_pub_ip:
+    if associate_public_ip:
         public_ip_name = repair_vm_name + "PublicIP"
     return public_ip_name