Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cisco umbrella playbook changes and repackage #11603

Merged
merged 109 commits into from
Jan 20, 2025
Merged

Cisco umbrella playbook changes and repackage #11603

merged 109 commits into from
Jan 20, 2025

Conversation

v-amolpatil
Copy link
Contributor

@v-amolpatil v-amolpatil commented Dec 26, 2024 •
edited
Loading

Required items, please complete

Change(s):

  • Playbook version changes for below 3 playbooks. Re-structrucing of folders, update readme for all playbooks with images.

    1. AddIpToDestinationList
    2. AssignPolicyToIdentity
    3. GetDomainInfo
    4. There is no change in BlockDomain playbook and its custom connector as the API is not deprecated for Enforcement.

Reason for Change(s):

  • V1 version is deprecated and upgraded to newer version v2 and updated readme links and its code. Repackaged solution as well.
  • This new version has lot of changes in legacy urls so we updated this as well.

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

Alekhya0824 and others added 30 commits May 7, 2024 10:40
@Alekhya0824
windows Event and security events split updated parsers
d040f31
@Alekhya0824
splited and update parser
60dbabe
@Alekhya0824
updated
4d2d7b2
@Alekhya0824
updated
2126f3b
@Alekhya0824
updated parser
94bf149
@Alekhya0824
updated
c0a3187
@Alekhya0824
Updated splited parser
92a1e62
@Alekhya0824
updated splitted parser
990fbc5
Merge remote-tracking branch 'origin/master' into Splitting_Parsers
d173925
[ASIM Parsers] Generate deployable ARM templates from KQL function YA…
30dfc85 
…ML files.
@Alekhya0824
Updated splitted Baracuda WAF and Baracuda CEF
876d264
@Alekhya0824
Merge branch 'Splitting_Parsers' of https://github.com/Azure/Azure-Se…
cb218d8 
…ntinel into Splitting_Parsers
Merge remote-tracking branch 'origin/master' into Splitting_Parsers
192cf24
[ASIM Parsers] Generate deployable ARM templates from KQL function YA…
e0b9b82 
…ML files.
@Alekhya0824
Updated splitted Baracuda WAF and Baracuda CEF
45bcb0c
@Alekhya0824
Updated splitted Baracuda WAF and Baracuda CEF
5c305c1
@Alekhya0824
Updated splited Baracuda WAF and Baracuda CEF
ab26e61
[ASIM Parsers] Generate deployable ARM templates from KQL function YA…
6aa53b5 
…ML files.
@Alekhya0824
Merge branch 'Splitting_Parsers' of https://github.com/Azure/Azure-Se…
ebeed7b 
…ntinel into Splitting_Parsers
[ASIM Parsers] Generate deployable ARM templates from KQL function YA…
979a3ca 
…ML files.
@Alekhya0824
comments updated
22cb932
Merge remote-tracking branch 'origin/master' into Splitting_Parsers
1eda269
[ASIM Parsers] Generate deployable ARM templates from KQL function YA…
418ac0c 
…ML files.
@Alekhya0824
added schema and data results files
749cfc2
@Alekhya0824
updated
45d0f18
Merge remote-tracking branch 'origin/master' into Splitting_Parsers
86a7945
[ASIM Parsers] Generate deployable ARM templates from KQL function YA…
68ec02f 
…ML files.
@Alekhya0824
UPDATED
3cecfae
@Alekhya0824
Merge branch 'Splitting_Parsers' of https://github.com/Azure/Azure-Se…
d222007 
…ntinel into Splitting_Parsers
Merge remote-tracking branch 'origin/master' into Splitting_Parsers
3ca9dc7
@v-amolpatil v-amolpatil marked this pull request as ready for review December 26, 2024 10:53
@v-amolpatil v-amolpatil requested review from a team as code owners December 26, 2024 10:53
rahul0216
rahul0216 reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mostly looks good. There are few spelling mistakes in readme files. Please correct those.

Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AssignPolicyToIdentity/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md Outdated Show resolved Hide resolved
rahul0216
rahul0216 previously approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Approved.

manishkumar1991
manishkumar1991 previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@manishkumar1991 manishkumar1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@v-amolpatil v-amolpatil requested a review from a team as a code owner January 20, 2025 09:05
@Azure Azure deleted a comment from contentautomationbot bot Jan 20, 2025
@Azure Azure deleted a comment from contentautomationbot bot Jan 20, 2025
@v-dvedak v-dvedak merged commit b2f891b into master Jan 20, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-dvedak v-dvedak v-dvedak approved these changes

@manishkumar1991 manishkumar1991 manishkumar1991 left review comments

@rahul0216 rahul0216 rahul0216 left review comments

Assignees

@rahul0216 rahul0216

@manishkumar1991 manishkumar1991

@v-amolpatil v-amolpatil

Labels
Content-Package Playbook Playbook specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@v-amolpatil @rahul0216 @manishkumar1991 @v-dvedak @Alekhya0824 @vakohl