Users/changliu2/ignite2024 hotfix random runs #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changliu2
requested review from
marlenezw and
cassiebreviu
and removed request for
marlenezw
YusakuNo1
approved these changes
Nov 16, 2024
marlenezw
reviewed
Nov 16, 2024
marlenezw
reviewed
Nov 16, 2024
src/api/agents/product/product.py
Outdated
| @@ -84,10 +84,25 @@ def retrieve_products(items, index_name): | |||
|
|
|||
|
|
|||
| @trace | |||
| def find_products(context: str) -> Dict[str, any]: | |||
| def find_products(context: str, num_retries: int = 3) -> Dict[str, any]: | |||
There was a problem hiding this comment.
We need to revise this code post Ignite. It sometimes works and sometimes does not. I'm finding it causes the product agent to break more times than not. Let's circle back soon
marlenezw
reviewed
Nov 16, 2024
|
|
||
| # Output format | ||
| Only output the full array of specialized queries to make to the search index. Limit | ||
| yoursef to 5 queries. | ||
|
|
||
| user: | ||
| {{context}} | ||
| context: {{context}} |
There was a problem hiding this comment.
I think the user input should not be in this format.
marlenezw
reviewed
Nov 16, 2024
src/api/agents/designer/designer.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| from openai import AzureOpenAI | |||
| from azure.identity import DefaultAzureCredential, get_bearer_token_provider | |||
|
|
|||
| def image_gen(image_prompt): | |||
| def image_gen(image_prompt: str): | |||
There was a problem hiding this comment.
We are currently not using the designer as dalle 3 availability is restricted
…hes; added retry logic up to 3 times and updated resaercher model to 4o
changliu2
force-pushed
the
users/changliu2/ignite2024-hotfix-random-runs
branch
from
e2bba7d to
aa52925
Compare
…~2m/article), and debugging msg to clarify use case of tracing
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Agents require GPT model output to follow certain format, but LLM models may behave non-deterministically and the code will error out. Errors rarely occur in products.py and researcher.py but they do.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
Retries may increase running time up to 3 times.
How to Test
What to Check
Verify that the following are valid
Other Information