-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PSRule for Security testing and re-enable manual testing #127
Conversation
targetScope = 'subscription' | ||
|
||
param environmentName string = 'testing' | ||
param location string = 'swedencentral' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use Sweden central here or East US 2 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's one of the allowed regions,it doesn't matter
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This looks good to me too! Just realised I need to update the workflow branch and confirming if the region. I think Sweden Central doesn't have semantic search functionality that is needed for this project |
That should probably be fixed separately then because it's one of the allowed regions and the most popular for AI deployments outside of the US |
Thanks for the PR, I'll document the issue!!! |
Purpose
This uses a different rule for security testing that reduces false-positives and validates only what is deployed.