Fixed tracing issues introduced by #159 (#164)

* Fixed tracing issues introduced by #159

* Added app_insights param to deactivate it for eval

src/api/evaluate/evaluate.py

@@ -156,7 +156,7 @@ def evaluate_row(research_context, product_context, assignment_context):
     # Use LOCAL_TRACING to determine if we should use the PromptyTracer locally
     # Never use remote_tracing for evaluation, it's not really relevant
     LOCAL_TRACING = True if os.getenv("LOCAL_TRACING", "false").lower() == "true" else False
-    tracer = init_tracing(local_tracing=LOCAL_TRACING, remote_tracing=False)
+    tracer = init_tracing(local_tracing=LOCAL_TRACING, remote_tracing=False, app_insights=False)
 
     eval_result = evaluate_orchestrator(model_config, data_path=folder +"/eval_inputs.jsonl")
 

src/api/orchestrator.py

@@ -170,6 +170,8 @@ def test_create_article():
 
 if __name__ == "__main__":
     from tracing import init_tracing
+    import os
 
-    tracer = init_tracing(remote_tracing=True, local_tracing=True)
+    LOCAL_TRACING = True if os.getenv("LOCAL_TRACING", "false").lower() == "true" else False
+    tracer = init_tracing(local_tracing=LOCAL_TRACING)
     test_create_article()

src/api/tracing.py

@@ -27,7 +27,7 @@ def verbose_trace(key, value):
         yield verbose_trace
 
 
-def init_tracing(remote_tracing: bool, local_tracing: bool = False):
+def init_tracing(local_tracing: bool = False, remote_tracing: bool = None, app_insights: bool = True):
     """
     Initialize tracing for the application
     If local_tracing is True, use the PromptyTracer
@@ -45,21 +45,21 @@ def init_tracing(remote_tracing: bool, local_tracing: bool = False):
     elif remote_tracing:
         Tracer.add("OpenTelemetry", trace_span)
 
-    azmon_logger = logging.getLogger("azure")
-    azmon_logger.setLevel(logging.INFO)
+    if app_insights:
+        azmon_logger = logging.getLogger("azure")
+        azmon_logger.setLevel(logging.INFO)
 
-    # oteltrace.set_tracer_provider(TracerProvider())
+        # oteltrace.set_tracer_provider(TracerProvider())
 
-    # Configure Azure Monitor as the Exporter
-    app_insights = os.getenv("APPINSIGHTS_CONNECTIONSTRING")
+        # Configure Azure Monitor as the Exporter
+        app_insights = os.getenv("APPINSIGHTS_CONNECTIONSTRING")
 
-    # Add the Azure exporter to the tracer provider
+        # Add the Azure exporter to the tracer provider
 
-    oteltrace.set_tracer_provider(TracerProvider(sampler=ParentBasedTraceIdRatio(1.0)))
-    oteltrace.get_tracer_provider().add_span_processor(BatchSpanProcessor(AzureMonitorTraceExporter(connection_string=app_insights)))
-    # oteltrace.get_tracer_provider().add_span_processor(
-    #     SimpleSpanProcessor(trace_exporter)
-    # )
-
-    return oteltrace.get_tracer(_tracer)
+        oteltrace.set_tracer_provider(TracerProvider(sampler=ParentBasedTraceIdRatio(1.0)))
+        oteltrace.get_tracer_provider().add_span_processor(BatchSpanProcessor(AzureMonitorTraceExporter(connection_string=app_insights)))
+        # oteltrace.get_tracer_provider().add_span_processor(
+        #     SimpleSpanProcessor(trace_exporter)
+        # )
 
+        return oteltrace.get_tracer(_tracer)