Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing external benchmarks memory problems #639

Closed
wants to merge 4 commits into from

Conversation

Rumata888
Copy link
Contributor

@Rumata888 Rumata888 commented Jul 27, 2023

Description

Charlie's memory management updates made it so we can't allocate some of our structures in global scope, which broke the benchmarks. This is a fix
Resolves #548

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
Copy link
Collaborator

ludamad commented Jul 27, 2023

Note AztecProtocol/aztec-packages#1174
Although as this continues to work in barretenberg repo I am taking a bit before looking into it again

@Rumata888
Copy link
Contributor Author

Merged int aztec-packages

@Rumata888 Rumata888 closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External benchmarks are broken by slab allocator
2 participants