Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Goblin work done in Valencia #569

Merged
merged 3 commits into from
Jul 17, 2023
Merged

feat: Goblin work done in Valencia #569

merged 3 commits into from
Jul 17, 2023

Conversation

codygunton
Copy link
Collaborator

@codygunton codygunton commented Jun 30, 2023 •
edited
Loading

Description

Adding the basic structure that abstractly describes elliptic curve operations for Goblin. Will be further developed by the other Goblin workstreams

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@codygunton codygunton changed the title Goblin work done in Valencia feat: Goblin work done in Valencia Jun 30, 2023
@codygunton codygunton changed the title feat: Goblin work done in Valencia BIG feat [don't merge yet]: Goblin work done in Valencia Jul 3, 2023
@codygunton codygunton changed the title BIG feat [don't merge yet]: Goblin work done in Valencia BIG feat: Goblin work done in Valencia Jul 4, 2023
@codygunton codygunton changed the title BIG feat: Goblin work done in Valencia feat: OpQueue Jul 17, 2023
@ledwards2225 ledwards2225 changed the title feat: OpQueue feat: Goblin work done in Valencia Jul 17, 2023
@codygunton codygunton marked this pull request as ready for review July 17, 2023 20:14
@ledwards2225 ledwards2225 self-requested a review July 17, 2023 20:26
ledwards2225
ledwards2225 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, lets do it

@ledwards2225 ledwards2225 merged commit 57af751 into master Jul 17, 2023
12 checks passed
@ledwards2225 ledwards2225 deleted the goblin-valencia branch July 17, 2023 20:27
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@codygunton
feat: Goblin work done in Valencia (AztecProtocol/barretenberg#569)
6c2e429
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@codygunton
feat: Goblin work done in Valencia (AztecProtocol/barretenberg#569)
1132777
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledwards2225 ledwards2225 ledwards2225 approved these changes

Assignees

@Rumata888 Rumata888

@codygunton codygunton

@ledwards2225 ledwards2225

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codygunton @ledwards2225 @Rumata888