Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Fix #219

Merged
merged 7 commits into from
Jul 8, 2024
Merged

CI Fix #219

merged 7 commits into from
Jul 8, 2024

Conversation

Oighty
Copy link
Contributor

@Oighty Oighty commented Jul 8, 2024

Seen two issues with the CI:

  1. pnpm failed to install on the develop branch. Bumped the version on the installer and that seemed to work.
  2. Tests fail on CI which pass locally with same salts. I believe this is due to the CI not using the same commits for the submodules. I'm updating the script to use the ./install.sh script to make them match.

@Oighty Oighty merged commit 27ed43d into develop Jul 8, 2024
1 check passed
@Oighty Oighty deleted the ci-fix branch July 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Oighty