Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-Uni Deployment Scripts #213

Merged
merged 30 commits into from
Jul 8, 2024
Merged

G-Uni Deployment Scripts #213

merged 30 commits into from
Jul 8, 2024

Conversation

0xJem
Copy link
Contributor

@0xJem 0xJem commented Jun 24, 2024

Improves the G-UNI scripts and associated documentation

  • Validate inputs
  • Add default RPCs
  • Working verification of contracts
  • Double-check that G-UNI deployment works with DTL

@0xJem 0xJem self-assigned this Jun 24, 2024
@0xJem 0xJem marked this pull request as draft June 24, 2024 13:41
@0xJem
Copy link
Contributor Author

0xJem commented Jun 24, 2024

I think the build is failing because there are different versions of OZ being used and the file has moved. Will need to figure out how to fix this.

@0xJem
Copy link
Contributor Author

0xJem commented Jun 26, 2024

After fixing the UniswapV2Router issue (as of https://github.com/Axis-Fi/deploy-uni-v2/commit/caac6a1dec90f44277726d9b8b9abea49c6acacb), I did testing on the testnets with forks.

Steps:

  • Create auction
  • Place bid
  • Warp to conclusion
  • Settle

Testing results:

Arb Sepolia:

  • Uni V2 callback
  • Uni V3 callback

Base Sepolia:

  • Uni V2 callback
  • Uni V3 callback

Blast Sepolia:

  • Uni V2 callback
  • Uni V3 callback

Mode Sepolia:

  • Uni V2 callback
  • Uni V3 callback

Blast Sepolia can't be tested as Tenderly does not support forks/testnets.

@0xJem
Copy link
Contributor Author

0xJem commented Jun 26, 2024

I'm going to list which deployments are our own, and then I think this is good to merge.

@0xJem 0xJem marked this pull request as ready for review June 27, 2024 09:05
@0xJem 0xJem requested a review from Oighty June 27, 2024 09:06
@Oighty Oighty merged commit 90dc724 into develop Jul 8, 2024
1 check passed
@Oighty Oighty deleted the deployment branch July 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants