-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ScrollViewerPresenter] Fix rtl scroll (#16667) #17714
base: master
Are you sure you want to change the base?
Conversation
You can test this PR using the following package version. |
@maxkatz6 Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
A couple of minor comments and this will be good to merge.
You can test this PR using the following package version. |
|
||
else | ||
{ | ||
delta = AdjustDeltaForFlowDirection(delta, FlowDirection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done unconditionally, not in an else
block. Otherwise, shift + scroll wheel is still reversed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. I think shift+scroll should remained the original behavior, as scrolling up means to show later content. Maybe ask some native Arabic speakers' opinion like @Mop1398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaict, at least on browsers, shift+wheel up scrolls left even with direction: rtl
.
But I'm no expert here, let's wait for a native speaker's input.
What does the pull request do?
Make
ScrollViewerPresenter
horizontal scroll more natural whenFlowDirection
set toRightToLeft
.Fix #16667.
What is the current behavior?
When
FlowDirection
set toRightToLeft
, swiping from right to left will move the left-hand-side content to the right.default.mp4
What is the updated/expected behavior with this PR?
When
FlowDirection
set toRightToLeft
, swiping from right to left should move the right-hand-side content to the left.default.mp4
Checklist
Fixed issues
Fix #16667.