-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keywords proposal #675
keywords proposal #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the obvious change on the attribute name...
I think this is far too detailed to be useful. And does not address the point: find what to use to do what. 'button' for example is not really helpful.
'dashboard' is good. People know what 'dashboard'-like applications are
'notebook' as well.
My proposal (note map- > maps):
gui, multi-page, layout, part, scenario, configuration, dag, cycle, scope, scenario_submission, standalone, scenario_comparison, subscription, storage_type, partials, studio, dashboard, classification, optimization, ai, maps, notebook, deployment, stylekit, cloud
If there are things that don't use any of those, we may want to extend it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. To answer Fabien's comment: I get the point, but "button" can still be helpful if I look for examples of how to use a button. Both proposed solutions are fine with me.
For instance, However, I kept the following keywords that were not in your proposal @FabienLelaquais:
They may have some interest. Let's talk about it later. |
I am merging the PR now to unblock another PR on the topic. We can discuss and change the keywords later if needed. |
I added a list of keywords for each kb_article. Here is the complete list:
@FabienLelaquais @FlorianJacta @AlexandreSajus please review for each article the list of keywords used. Please do not hesitate to propose adding or removing keywords to some articles.
Once we agree on the keywords we can use some of them as a filter (not all of them 'cause we don't want to have to many filter values and we don't want a filter to display only one article).
@Jaufrey is it the right place to add keywords ? on the
<li>
tag?