-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#416 core notification documentation #1120
Feature/#416 core notification documentation #1120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems your changes don't take into account the new structure of the documentation.
The file location should be on docs/userman/scenario_features/events/
Can you check that?
…fier.py Co-authored-by: Jean-Robin <[email protected]>
…fier.py Co-authored-by: Jean-Robin <[email protected]>
aa5962b
to
c744338
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You copy paste twice the same text🤣. To make it easier to review I already pushed my changes. I also did a few minor changes.
Remove duplicate text
Formatting and cross refs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Core as much as possible.
Added motivation description for some examples