Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#416 core notification documentation #1120

Merged
merged 18 commits into from
Sep 12, 2024

Conversation

toan-quach
Copy link
Member

@toan-quach toan-quach commented Sep 10, 2024

Added motivation description for some examples

Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems your changes don't take into account the new structure of the documentation.

The file location should be on docs/userman/scenario_features/events/

Can you check that?

@toan-quach toan-quach force-pushed the feature/#416-core-notification-documentation branch from aa5962b to c744338 Compare September 11, 2024 03:00
@toan-quach toan-quach requested a review from jrobinAV September 11, 2024 03:06
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You copy paste twice the same text🤣. To make it easier to review I already pushed my changes. I also did a few minor changes.

docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
Remove duplicate text
Formatting and cross refs
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Core as much as possible.

docs/userman/scenario_features/events/examples.md Outdated Show resolved Hide resolved
@toan-quach toan-quach merged commit 4220977 into develop Sep 12, 2024
1 check passed
@toan-quach toan-quach deleted the feature/#416-core-notification-documentation branch September 12, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants