Fix image links and rest refman #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobinAV
approved these changes
Sep 9, 2024
| @@ -100,7 +100,7 @@ def get_property_type(property_desc, from_schemas): | |||
| if dest_path in enterprise_paths: | |||
| file.write(Setup.ENTERPRISE_BANNER) | |||
| file.write(f"{dest_path_desc}\n\n") | |||
| self.navigation += f"- \"Paths for {dest_path}\": {REST_REF_DIR_PATH}/apis_{dest_path}.md\n" | |||
| self.navigation += f'- "Paths for {dest_path}": refmans/reference_rest/apis_{dest_path}.md\n' | |||
There was a problem hiding this comment.
Can't you use the REST_REF_DIR_PATH variable? What is the issue?
There was a problem hiding this comment.
This is the error. I cannot use REST_REF_DIR_PATH as it is the absolute path to the file and the goal here is to use the relative path for the navigation
Comment on lines
-125
to
+134
| file.write(f'<div><h4 style="display: inline-block;">Request body:</h4>\n') | ||
| schema = request_body["content"]["application/json"]["schema"]["$ref"] | ||
| file.write( | ||
| f'<div><h4 style="display: inline-block;">Request body:</h4>\n' | ||
| ) | ||
| schema = request_body["content"]["application/json"]["schema"][ | ||
| "$ref" | ||
| ] | ||
| schema = schema[schema.rfind("/") + 1 :] | ||
| file.write(f'<span><a href="schemas.md#{schema.lower()}">{schema}</a></div>\n\n') | ||
| file.write( | ||
| f'<span><a href="schemas.md#{schema.lower()}">{schema}</a></div>\n\n' | ||
| ) |
There was a problem hiding this comment.
I believe your automatic formatting is incorrect. Can you check?
There was a problem hiding this comment.
I am using Black to format the code. What do I have to do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1114
There was an error in how the Rest Refman was generated. I fixed the issue by not using the absolute path.