-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get execution #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t tried this but the code looks good.
On another note, I think we could remove the /dist
folder and the files in the grpc_codegen
folder except the grpc_codegen/avs.proto
.
They were added in the first place because I had to manually update some code, but the auto-gen npm commands work pretty deterministic now, I don’t think we need them in this source code repo. They can always be generated for npm distribution. @v9n what do you think? If you agree could you create another PR to remove them?
Yes, I'm on board. This make it much easiser becasue we can run test directly without npm run build |
Let’s merge this PR after #50, with the below changes. Source files: |
build fail because the workspace refactor broken it. will address in pr #52 |
No description provided.