Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get execution #48

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Update get execution #48

merged 7 commits into from
Jan 7, 2025

Conversation

v9n
Copy link
Member

@v9n v9n commented Jan 2, 2025

No description provided.

Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t tried this but the code looks good.

On another note, I think we could remove the /dist folder and the files in the grpc_codegen folder except the grpc_codegen/avs.proto.

They were added in the first place because I had to manually update some code, but the auto-gen npm commands work pretty deterministic now, I don’t think we need them in this source code repo. They can always be generated for npm distribution. @v9n what do you think? If you agree could you create another PR to remove them?

@v9n
Copy link
Member Author

v9n commented Jan 6, 2025

On another note, I think we could remove the /dist folder and the files in the grpc_codegen folder except the grpc_codegen/avs.proto.

They were added in the first place because I had to manually update some code, but the auto-gen npm commands work pretty deterministic now, I don’t think we need them in this source code repo. They can always be generated for npm distribution. @v9n what do you think? If you agree could you create another PR to remove them?

Yes, I'm on board.

This make it much easiser becasue we can run test directly without npm run build

@chrisli30
Copy link
Member

Let’s merge this PR after #50, with the below changes.

Source files: /src -> packages/sdk-js/src/
Test files and the rest: no change

@v9n
Copy link
Member Author

v9n commented Jan 7, 2025

build fail because the workspace refactor broken it. will address in pr #52

@v9n v9n merged commit b7259c5 into main Jan 7, 2025
2 of 6 checks passed
@v9n v9n deleted the update-get-execution branch January 7, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants