Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social previews | Remove learn more for link previews #98930

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Jan 27, 2025

Fixes Automattic/jetpack#41063

Proposed Changes

  • Remove the needless learn more link in Social Previews components which anyway points to the wrong documentation.
Screenshot 2025-01-27 at 4 59 22 PM

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 27, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~77 bytes removed 📉 [gzipped])

name          parsed_size           gzip_size
posts-custom      -1114 B  (-0.2%)      -77 B  (-0.0%)
posts             -1114 B  (-0.2%)      -77 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~77 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks      -1114 B  (-0.1%)      -77 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/social-previews-to-remove-learn-more-for-link-previews on your sandbox.

@manzoorwanijk manzoorwanijk marked this pull request as ready for review January 27, 2025 11:38
@manzoorwanijk manzoorwanijk self-assigned this Jan 27, 2025
@manzoorwanijk manzoorwanijk requested a review from a team January 27, 2025 11:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 27, 2025
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@manzoorwanijk manzoorwanijk merged commit 0bb16c9 into trunk Jan 29, 2025
18 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social-previews-to-remove-learn-more-for-link-previews branch January 29, 2025 13:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Social: Link Preview Documentation
3 participants