Redirect user to home page when home/launchpad-first is enabled #98835

paulopmt1 · 2025-01-23T17:10:14Z

Also enabled it on dev by default since we lose that flag when redirecting through pages

Related to #98812

Proposed Changes

After creating the user's site, we're redirecting them to the new /home launchpad instead of /launchpad

Why are these changes being made?

This is part of Launchpad In My Home project: pet6gk-1T7-p2

Testing Instructions

Make sure you restart your yarn start command so your local development will use the "home/launchpad-first": true flag value
Go through the onboarding flow and once it's finished, you should land at the new home Launchpad:

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-01-23T17:10:30Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131048

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131048&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131048&env=a8c-for-agencies

matticbot · 2025-01-23T17:11:27Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~137 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
write-flow                 +407 B  (+0.0%)      +91 B  (+0.0%)
link-in-bio-tld-flow       +407 B  (+0.0%)      +91 B  (+0.0%)
build-flow                 +407 B  (+0.0%)      +91 B  (+0.0%)
home                       +214 B  (+0.0%)      +46 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

vykes-mac · 2025-01-23T18:30:52Z

There's an error at times in the launchpad, It's not related to this PR but just calling out.

Screen.Recording.2025-01-23.at.1.27.57.PM.mov

This PR works to redirect to launchpad my home.

client/landing/stepper/declarative-flow/site-setup-flow.ts

zaguiini

I was thinking if this is the right solution.

In my head, redirecting within the Launchpad component would make sense, because then whenever they tried to enter any Launchpad flow step (after creating a site of course), they'd be sent home. This is especially true in cases where they click the onboarding link in emails or the help center. It's usually /setup/(flowname)/launchpad.

Now, the site-setup or onboarding flows don't have a Launchpad, so it depends on the intent of the site (write or build in this case.) Maybe we could do this differently, and within the Launchpad step redirect the user home if:

They have created the site through onboarding
Their intent is write or build (we can use the same helper function)
The feature flag is on?

🤔

zaguiini · 2025-01-24T00:26:57Z

client/landing/stepper/declarative-flow/site-setup-flow.ts

@@ -296,6 +297,10 @@ const siteSetupFlow: FlowV1 = {
 					}

 					if ( isLaunchpadIntent( intent ) ) {


We could write this as if ( isLaunchpadIntent( intent ) && ! config.isEnabled( 'home/launchpad-first' ) )

zaguiini · 2025-01-24T00:30:30Z

cc @autumnfjeld #98835 (review)

config/development.json

zaguiini · 2025-01-24T17:03:33Z

client/landing/stepper/declarative-flow/internals/steps-repository/launchpad/index.tsx

@@ -96,6 +97,11 @@ const Launchpad: Step = ( { navigation, flow }: LaunchpadProps ) => {
 		return;
 	}

+	if ( config.isEnabled( 'home/launchpad-first' ) ) {


I believe we should also check if the site_creation_flow is onboarding because we want to gate the changes to that flow.

Like this. I think we can even extract that function to its own file and reuse it here 👍🏻

Good idea, reused it here: 1189aac

Also enabled it on dev by default since we lose that flag when redirecting through pages

zaguiini

👍🏻

client/state/selectors/should-show-launchpad-first.js

client/landing/stepper/declarative-flow/internals/steps-repository/launchpad/index.tsx

matticbot · 2025-01-24T20:10:54Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/redirect-to-home-on-lauchpad-first on your sandbox.

paulopmt1 linked an issue Jan 23, 2025 that may be closed by this pull request

Task: Redirect users to the new full screen launchpad after the onboarding flow #98812

Closed

2 tasks

paulopmt1 requested a review from a team January 23, 2025 18:10

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 23, 2025

vykes-mac approved these changes Jan 23, 2025

View reviewed changes

Base automatically changed from launchpad-first/avoid-fs-launchpad-redirect to trunk January 23, 2025 20:47

zaguiini reviewed Jan 23, 2025

View reviewed changes

client/landing/stepper/declarative-flow/site-setup-flow.ts Outdated Show resolved Hide resolved

zaguiini reviewed Jan 24, 2025

View reviewed changes

zaguiini force-pushed the update/redirect-to-home-on-lauchpad-first branch from cd602bf to 6768100 Compare January 24, 2025 00:33

zaguiini reviewed Jan 24, 2025

View reviewed changes

config/development.json Outdated Show resolved Hide resolved

zaguiini reviewed Jan 24, 2025

View reviewed changes

paulopmt1 requested review from a team as code owners January 24, 2025 17:59

paulopmt1 removed request for a team January 24, 2025 18:00

paulopmt1 added 3 commits January 24, 2025 15:00

Redirect user to home page when home/launchpad-first is enabled

c81471a

Also enabled it on dev by default since we lose that flag when redirecting through pages

Moved the redirect for the launchpad instead of site-setup flow

a1dcf7c

create a selector to reuse across components

1189aac

paulopmt1 force-pushed the update/redirect-to-home-on-lauchpad-first branch from 548865c to 1189aac Compare January 24, 2025 18:01

Disabling launch first on dev by default

dc5b68f

paulopmt1 requested a review from zaguiini January 24, 2025 18:59

zaguiini approved these changes Jan 24, 2025

View reviewed changes

client/state/selectors/should-show-launchpad-first.js Outdated Show resolved Hide resolved

client/landing/stepper/declarative-flow/internals/steps-repository/launchpad/index.tsx Outdated Show resolved Hide resolved

Final improvements from PR review

c3314f5

zaguiini approved these changes Jan 24, 2025

View reviewed changes

Created a unit test to ensure selector's behavior

27b2a3e

paulopmt1 merged commit 853694d into trunk Jan 24, 2025
13 checks passed

paulopmt1 deleted the update/redirect-to-home-on-lauchpad-first branch January 24, 2025 20:25

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect user to home page when home/launchpad-first is enabled #98835

Redirect user to home page when home/launchpad-first is enabled #98835

paulopmt1 commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited by matticbot

Loading

matticbot commented Jan 23, 2025 •

edited

Loading

vykes-mac commented Jan 23, 2025

zaguiini left a comment •

edited

Loading

zaguiini Jan 24, 2025

zaguiini commented Jan 24, 2025

zaguiini Jan 24, 2025

paulopmt1 Jan 24, 2025

zaguiini left a comment

matticbot commented Jan 24, 2025 •

edited

Loading

		@@ -296,6 +297,10 @@ const siteSetupFlow: FlowV1 = {
		}

		if ( isLaunchpadIntent( intent ) ) {

Redirect user to home page when home/launchpad-first is enabled #98835

Redirect user to home page when home/launchpad-first is enabled #98835

Conversation

paulopmt1 commented Jan 23, 2025 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jan 23, 2025 • edited by matticbot Loading

matticbot commented Jan 23, 2025 • edited Loading

vykes-mac commented Jan 23, 2025

zaguiini left a comment • edited Loading

Choose a reason for hiding this comment

zaguiini Jan 24, 2025

Choose a reason for hiding this comment

zaguiini commented Jan 24, 2025

zaguiini Jan 24, 2025

Choose a reason for hiding this comment

paulopmt1 Jan 24, 2025

Choose a reason for hiding this comment

zaguiini left a comment

Choose a reason for hiding this comment

matticbot commented Jan 24, 2025 • edited Loading

paulopmt1 commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited by matticbot

Loading

matticbot commented Jan 23, 2025 •

edited

Loading

zaguiini left a comment •

edited

Loading

matticbot commented Jan 24, 2025 •

edited

Loading