Remove obsolete code from Students area #7726
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Automattic/sensei-security/issues/19.
Proposed Changes
While working on #7724, I noticed that code that used to run in the Students area when the URL had the
view=courses
query parameter, or when the URL had noview
parameter, appears to be obsolete. I clicked through all of the Students screens and was unable to find an instance where there was noview
parameter or whereview
was set tocourses.
I then reverted Sensei to version 4.3, which is the release prior to the one in which we overhauled Learner Management. In that version, the default screen that displayed when clicking Student Management did indeed set the
view
property tocourses
and execute this code. So I think we just missed removing this obsolete code back then, and I'm going ahead and ripping the bandaid off now. 😬Testing Instructions
Pre-Merge Checklist