Change launchMode on MainActivity from "singleTop" to "singleTask" #3126
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking at the Android documentation, it seems like the
singleTask
launchMode
is more correct to the Gravatar'sMainActivity
.vs
Despite being just a one-line change, please smoke test everything that comes to your mind related to how the activity is launched. I've done the same, but I have limited knowledge of the code base.
cc: @MiSikora
Testing Instructions
Checklist
- [ ] If this is a user-facing change, I have added an entry in CHANGELOG.md- [] Ensure the linter passes (./gradlew spotlessApply
to automatically apply formatting/linting)- [ ] I have considered whether it makes sense to add tests for my changes- [ ] All strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
- [ ] Any jetpack compose components I added or changed are covered by compose previews- [ ] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...
- [ ] with different themes- [ ] with a landscape orientation- [ ] with the device set to have a large display and font size- [ ] for accessibility with TalkBack