-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Playback Settings - Apply local/ global settings #3088
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
if (FeatureFlag.isEnabled(Feature.CUSTOM_PLAYBACK_SETTINGS)) { | ||
podcastDao.findByUuid(podcastUuid)?.let { localPodcast -> | ||
podcast.copyPlaybackEffects( | ||
sourcePodcast = localPodcast, | ||
) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm copying local playback effects to the podcast here so that local playback effects are not lost while subscribing to it.
Looking forward to this, Is their a chance with this project that settings sync only for playback fx be enabled? Obviously theirs risk I get that but if local settings get saved and synced this will save so much time on new devices & even if it mucks up its way less steps then it was previously 🤔 |
Thanks for the reminder!
Syncing podcast-level effects settings is out-of-scope for this project. There could be updates in the future. 🤞 |
# Conflicts: # modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/EffectsFragment.kt # modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/SegmentedTabBar.kt
Description
This applies local/ global settings to the current playing episode using the new segemented bar control.
** Ignore local files for now
Part of #3042
Testing Instructions
Test Global Effects Settings
All Podcasts
is selectedThis podcast
updates the view by changing the settingsAll podcasts
the previous settings are appliedAll podcasts
Test Local Effects Settings
All Podcasts
is selectedThis podcast
tabAll podcasts
updates the view by changing the settingsThis podcast
the previous settings are appliedThis podcast
Screenshots or Screencast
global_and_local_playback_effects.mp4
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...