Custom Playback Settings - Apply local/ global settings #3088

ashiagr · 2024-10-24T12:26:42Z

Description

This applies local/ global settings to the current playing episode using the new segemented bar control.

** Ignore local files for now

Part of #3042

Testing Instructions

Test Global Effects Settings

Play an episode and open the Effects view
Make sure the All Podcasts is selected
Apply some changes
Verify that selecting This podcast updates the view by changing the settings
Verify that tapping back to All podcasts the previous settings are applied
Verify the global settings are applied to all podcasts episode and that the selected tab is always All podcasts
Navigate to the podcast page settings and verify that the local effects settings switch is off

Test Local Effects Settings

Play an episode and open the Effects view
Make sure the All Podcasts is selected
Select This podcast tab
Apply some changes
Verify that selecting All podcasts updates the view by changing the settings
Verify that tapping back to This podcast the previous settings are applied
Verify that the settings are applied to this podcast only
Verify that when opening the Effects view in this podcast, the tab selected is always This podcast
Navigate to the podcast page settings and verify that the local effects settings switch is on (if you haven't subscribed to this podcast, make sure to subscribe to it)

Screenshots or Screencast

global_and_local_playback_effects.mp4

Checklist

If this is a user-facing change, I have added an entry in CHANGELOG.md
Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
I have considered whether it makes sense to add tests for my changes
All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previews
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

with different themes
with a landscape orientation
with the device set to have a large display and font size
for accessibility with TalkBack

dangermattic · 2024-10-24T12:28:16Z

	1 Warning
⚠️	Class `PlaybackEffectsSettingsTab` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by 🚫 Danger

wpmobilebot · 2024-10-24T12:29:37Z

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.

	App Name	📱 Mobile
	Build Type	debugProd
	Commit	`ffa9f9a`
	Direct Download	`pocketcasts-app-prototype-build-pr3088-ffa9f9a.apk`

📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.

	App Name	🚗 Automotive
	Build Type	debugProd
	Commit	`ffa9f9a`
	Direct Download	`pocketcasts-automotive-prototype-build-pr3088-ffa9f9a.apk`

📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.

	App Name	⌚ Wear
	Build Type	debugProd
	Commit	`ffa9f9a`
	Direct Download	`pocketcasts-wear-prototype-build-pr3088-ffa9f9a.apk`

ashiagr · 2024-10-24T12:34:19Z

...tories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/podcast/SubscribeManager.kt

+                if (FeatureFlag.isEnabled(Feature.CUSTOM_PLAYBACK_SETTINGS)) {
+                    podcastDao.findByUuid(podcastUuid)?.let { localPodcast ->
+                        podcast.copyPlaybackEffects(
+                            sourcePodcast = localPodcast,
+                        )
+                    }
+                }


I'm copying local playback effects to the podcast here so that local playback effects are not lost while subscribing to it.

CookieyedCodes · 2024-10-25T06:54:55Z

Looking forward to this,
Just a reminder that files uses global and some tests might need to be done because unfortunately their is no local toggle for files,

Is their a chance with this project that settings sync only for playback fx be enabled? Obviously theirs risk I get that but if local settings get saved and synced this will save so much time on new devices & even if it mucks up its way less steps then it was previously 🤔

ashiagr · 2024-10-25T12:22:54Z

@CookieyedCodes 👋

Just a reminder that files uses global and some tests might need to be done because unfortunately their is no local toggle for files,

Thanks for the reminder!

Is their a chance with this project that settings sync only for playback fx be enabled? Obviously theirs risk I get that but if local settings get saved and synced this will save so much time on new devices & even if it mucks up its way less steps then it was previously 🤔

Syncing podcast-level effects settings is out-of-scope for this project. There could be updates in the future. 🤞

# Conflicts: # modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/EffectsFragment.kt # modules/services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/SegmentedTabBar.kt

ashiagr added 9 commits October 21, 2024 18:29

Add feature flag

5192a0b

Rename and update segmented tab bar style

1430b70

Display playback effects segmented control

ab2ba2f

Fix accessibility

f9337c1

Move setup to onCreateView

433eddb

Update style

64c14cf

Update playback effects on tab change

92579fe

Hide globalEffectsCard if FF enabled

1bff2fa

Copy local podcast playback effects to just subscribed podcast

5bd9a66

ashiagr added [Type] Feature Adding a new feature. do not merge [Project] Custom Playback Settings labels Oct 24, 2024

ashiagr added this to the Future milestone Oct 24, 2024

ashiagr commented Oct 24, 2024

View reviewed changes

ashiagr added the unit-tests-exemption label Oct 25, 2024

ashiagr marked this pull request as ready for review October 25, 2024 04:21

ashiagr requested a review from a team as a code owner October 25, 2024 04:21

ashiagr requested review from geekygecko and removed request for a team October 25, 2024 04:21

ashiagr mentioned this pull request Oct 25, 2024

Custom Playback Settings #3042

Open

geekygecko approved these changes Oct 25, 2024

View reviewed changes

Base automatically changed from task/3042-add-ff-and-control to main October 28, 2024 05:08

ashiagr removed the do not merge label Oct 28, 2024

ashiagr added 2 commits October 28, 2024 10:40

Fix merge

ffa9f9a

ashiagr enabled auto-merge (squash) October 28, 2024 05:17

ashiagr merged commit c8f1bd8 into main Oct 28, 2024
16 checks passed

ashiagr deleted the task/3042-local-global-logic branch October 28, 2024 05:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Playback Settings - Apply local/ global settings #3088

Custom Playback Settings - Apply local/ global settings #3088

ashiagr commented Oct 24, 2024 •

edited

Loading

dangermattic commented Oct 24, 2024 •

edited

Loading

wpmobilebot commented Oct 24, 2024 •

edited

Loading

ashiagr Oct 24, 2024

CookieyedCodes commented Oct 25, 2024 •

edited

Loading

ashiagr commented Oct 25, 2024

Custom Playback Settings - Apply local/ global settings #3088

Custom Playback Settings - Apply local/ global settings #3088

Conversation

ashiagr commented Oct 24, 2024 • edited Loading

Description

Testing Instructions

Screenshots or Screencast

Checklist

I have tested any UI changes...

dangermattic commented Oct 24, 2024 • edited Loading

wpmobilebot commented Oct 24, 2024 • edited Loading

ashiagr Oct 24, 2024

Choose a reason for hiding this comment

CookieyedCodes commented Oct 25, 2024 • edited Loading

ashiagr commented Oct 25, 2024

ashiagr commented Oct 24, 2024 •

edited

Loading

dangermattic commented Oct 24, 2024 •

edited

Loading

wpmobilebot commented Oct 24, 2024 •

edited

Loading

CookieyedCodes commented Oct 25, 2024 •

edited

Loading