Fix effects being lost when paused #3084
Open
+65
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekygecko
added
[Type] Bug
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
geekygecko
commented
Oct 24, 2024
| remainingTimeText.contentDescription = resources.getString(LR.string.player_time_remaining, remaingingTime.removePrefix("-")) | ||
| val remainingTime = (-remainingDuration()).toHhMmSs() | ||
| remainingTimeText.text = remainingTime | ||
| remainingTimeText.contentDescription = resources.getString(LR.string.player_time_remaining, remainingTime.removePrefix("-")) |
geekygecko
commented
Oct 24, 2024
| podcast = podcast, | ||
| chapters = if (sameEpisode) (previousPlaybackState?.chapters ?: Chapters()) else Chapters(), | ||
| lastChangeFrom = LastChangeFrom.OnUpdatePausedPlaybackState.value, |
There was a problem hiding this comment.
The playback effects were not being added here.
I tried changing local playback effects and those reverted to the original value in a paused state: time.changed.webm |
mebarbosa
reviewed
Oct 28, 2024
Comment on lines
+10
to
13
| * Bug Fixes | ||
| * Fix effects being lost when paused | ||
| ([#3084](https://github.com/Automattic/pocket-casts-android/pull/3084)) | ||
| * Updates |
There was a problem hiding this comment.
@geekygecko I've moved this PR to 7.77. Please, make sure you update the changelog of this PR to 7.77 too
Thanks for finding this, I will work on a fix tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the app is first open or playback is paused, the player doesn't show that the playback effects are enabled. The reason is that a new PlaybackState is created without the effects.
I have tried to group the initialisation logic and put it in the PlaybackState object. I'm not sure if it should just in the PlaybackManager. 🤔
Fixes #3057
Testing Instructions
Video
Screen.Recording.2024-10-24.at.5.23.39.pm.mov
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...