-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Protection: Remove strict mode #41316
Account Protection: Remove strict mode #41316
Conversation
…add/protect/account-protection-settings
…add/protect/account-protection-settings
…add/protect/account-protection-settings
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
No changelog entries necessary here as this is only reverting changes made in a prior PR that was already merged into the project branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works wonderfully. The both views are a bit inconsistent because:
- In Jetpack we explain with the small "info" icon a bit more about what this setting actually does, I think we should too in Protect, and
- In Jetpack, we don't display the recommendation to enable it when it is disabled, I think we should?
But both of these can be addressed in a future PR.
Thx @ArSn!
I've gone ahead and added these as a comment for the tasks that relate to finalizing the Jetpack and Protect UIs. |
Description
Removes the strict mode toggle in Jetpack and Protect and all related package code.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Screenshots
Jetpack:
Protect: