Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support net6.0 and net8.0 #166

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ricaun
Copy link
Contributor

@ricaun ricaun commented Jul 30, 2024

This PR add support for NET Code 6.0 and NET Code 8.0.

The package gonna have an assembly for both versions.

Until Microsoft.Extensions.DependencyInjection supports net6.0 is a good idea to support as well.

@szilvaa
Copy link
Collaborator

szilvaa commented Jul 30, 2024

Until Microsoft.Extensions.DependencyInjection supports net6.0 is a good idea to support as well.

I think that's a bit of presentation problem on the website. The package itself supports .net8:
https://nuget.info/packages/Microsoft.Extensions.DependencyInjection/8.0.0

@szilvaa
Copy link
Collaborator

szilvaa commented Jul 30, 2024

I'm a bit reluctant to add back .net6 support 3 months before .net6 is out of support. People need to move on. The old package that supports .net6 is still available.

@ricaun
Copy link
Contributor Author

ricaun commented Jul 31, 2024

I'm a bit reluctant to add back .net6 support 3 months before .net6 is out of support. People need to move on. The old package that supports .net6 is still available.

Rollback the version is annoying yes, but the version 4.0.1 has documentation and old version don't have that.

And the package gonna be ready when and if you update the DependencyInjection to version 9.0.0 that does not support net6.0, only net8.0 and net9.0.

image

When creating a package I always create in the same/lowest version supported by the dependencies, and currently version net6.0 is supported.

@szilvaa
Copy link
Collaborator

szilvaa commented Jul 31, 2024

Can you describe the scenario where .net6 must be used for new code (the documentation is only relevant for the programmer writing new code)?

@ricaun
Copy link
Contributor Author

ricaun commented Aug 3, 2024

Can you describe the scenario where .net6 must be used for new code (the documentation is only relevant for the programmer writing new code)?

The only scenario I use that package is inside some libraries I have, that is build in net6.

I'm already glad that new docs was added and a Guthub Release exists.

I personally would never remove a target framework before the end of the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants