Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation in Autodesk.Forge.Core #165

Merged
merged 18 commits into from
Jul 25, 2024

Conversation

ricaun
Copy link
Contributor

@ricaun ricaun commented Jul 24, 2024

Adding missing documentation in the Autodesk.Forge.Core project.

Copy link
Collaborator

@szilvaa szilvaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR.

Directory.Build.props Show resolved Hide resolved
@ricaun
Copy link
Contributor Author

ricaun commented Jul 24, 2024

Kinda have a question why the TargetFramework changed to net8.0?

The projects still build with net6.0, I don't understand the reason, I still can use the net6.0 package in a net8.0 project.

Using <TargetFrameworks>net6.0;net8.0</TargetFrameworks> would build in both versions. 😄

@szilvaa
Copy link
Collaborator

szilvaa commented Jul 25, 2024

Kinda have a question why the TargetFramework changed to net8.0?

.net6 will be out of support in a few months.

@szilvaa szilvaa merged commit b5b4065 into Autodesk-Forge:main Jul 25, 2024
2 checks passed
@ricaun
Copy link
Contributor Author

ricaun commented Jul 30, 2024

Kinda have a question why the TargetFramework changed to net8.0?

.net6 will be out of support in a few months.

Usually packages are built on the lowest version to give more flexibility to the user, I was wondering if this package should be netstandard2.0 to join the main ASP SDK ecosystem. I think this will never happen.

Anyway, could you please create a Release in this project to match the NuGet release. By releasing in the GitHub everyone that like this project or interact in some way gonna be know that the version 4.0.1 is released.

@szilvaa
Copy link
Collaborator

szilvaa commented Jul 30, 2024

netstandard2.0 to join the main ASP SDK ecosystem. I think this will never happen.

Yes, there's no plan to support netstandard2.0 again. Note that we used to, but it lacked some APIs that we wanted to use so we moved to .net(core). I expect that moving forward this package will upgrade to .net LTS releases like Autodesk desktop products.

@ricaun
Copy link
Contributor Author

ricaun commented Jul 30, 2024

Yes, there's no plan to support netstandard2.0 again. Note that we used to, but it lacked some APIs that we wanted to use so we moved to .net(core). I expect that moving forward this package will upgrade to .net LTS releases like Autodesk desktop products.

Yep, netstandard2.0 is kinda complicated I tried but to many strong dependencies with net code.

About supporting net6.0 and net8.0 is kinda simple to do it, I gonna create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants