Copy isSecure() property from JSR356 Session
#2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, it's impossible to know if a connection is done using SSL or not.
slovdahl
force-pushed
the
copy-secure-property-from-JSR356-session
branch
from
5e79d38
to
32b20ab
Compare
jfarcand
approved these changes
Aug 9, 2024
|
@jfarcand do you mind if I publish 3.0.9 with this fix? |
|
Side note, should we switch the default branch to
|
|
Perfect approved 😝
Le sam. 10 août 2024 à 15:14, Sebastian Lövdahl ***@***.***>
a écrit :
… @jfarcand <https://github.com/jfarcand> do you mind if I publish 3.0.9
with this fix?
—
Reply to this email directly, view it on GitHub
<#2512 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMQVPDU5JG57XIULO3ON3ZQZRCTAVCNFSM6AAAAABMIFRSSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGI2TANRWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Agree. Do you have the time to do it? I’m on vacation for a couples of
weeks .
Le sam. 10 août 2024 à 15:25, Sebastian Lövdahl ***@***.***>
a écrit :
… Side note, should we switch the default branch to main and also remove
this line from the README?
Main development branch is atmosphere-2.7.x
<https://github.com/Atmosphere/atmosphere/tree/atmosphere-2.7.x> Only
pull request for that branch will be accepted.
—
Reply to this email directly, view it on GitHub
<#2512 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMQVKLRGUAY44HDUGACDLZQZSEVAVCNFSM6AAAAABMIFRSSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGI2TEOBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hmm, I published 3.0.9 built with JDK 8 😁 It did build without problems. But I now noticed that the README says 3.0.x requires JDK 11. Should I rebuilt it with 11 and publish 3.0.10? 🤔 |
|
I'm redoing the release as 3.0.10 built with JDK 11. |
|
@jfarcand I don't have access to change the default branch. But I have now updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it's impossible to know if a connection is done using SSL or not.