Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register websocket endpoints for /mapping/ for /mapping/* servlets #2326

Open
wants to merge 2 commits into
base: master-deprecated
Choose a base branch
from
Open

Register websocket endpoints for /mapping/ for /mapping/* servlets #2326

wants to merge 2 commits into from

Commits on Apr 25, 2018

  1. Revert "Register websocket endpoints for /mapping/ for /mapping/* ser… 

    …vlets"

This reverts commit 14367ba.
    @Artur-
    Artur- committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    a9ed1bf View commit details
    Browse the repository at this point in the history

  2. Register websocket endpoints for /mapping/ for /mapping/* servlets 

    Previously for a servlet mapped using /mapping/*, there were mappings done for:
* /mapping
* /mapping/{path1}
* /mapping/{path1}/{path2}
etc

which do not match /mapping/

Tomcat disallows registering websocket endpoints using a trailing slash, except
for /servletMapping/. According to the code this is because
"As per EG discussion, all other empty segments are invalid"
    @Artur-
    Artur- committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    e98242b View commit details
    Browse the repository at this point in the history