Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more uses of AList/AListElem #218

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Remove more uses of AList/AListElem #218

merged 4 commits into from
Sep 28, 2024

Commits on Sep 27, 2024

  1. Remove the AList from shields

    Shields are now an stl container.  Reimplemented get highest shield
    in terms of the STL in-place since it was only used once and got rid
    of the shieldlist class as well.  In order to simplify memory management
    replaces the Shield * with shared_ptr<Shield> which provides a smart
    ref-counted pointer, so that just clearing (or erasing) an element from
    the container will delete the allocated memory.
    jt-traub committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    23cf3b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Quests no longer use AList

    Removed all uses of AList from the quests system (quests and rewards).
    Retained the QuestList class since it had a number of useful functions
    and reworked it using an internal std::vector.  Renamed all the
    member functions to follow intended style going forward.
    jt-traub committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1d47364 View commit details
    Browse the repository at this point in the history
  2. Remove AListElem from Productions

    This had mostly been done, so this was just cleaning up a leftover
    place or two where it hadn't been fully removed.  Also renamed the
    production class's functions using the new style.
    jt-traub committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8a7ecbf View commit details
    Browse the repository at this point in the history
  3. Update Markets to no longer use AList

    This has been partially done previously, this was just cleaning up
    some leftover turds.  Renamed Market class functions to use new
    style of naming.  Make the enum type for the market into a named
    enum.
    jt-traub committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1e48676 View commit details
    Browse the repository at this point in the history