-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIS-231 Add notification to Koha exporter if offline mode is enabled #2202
base: 25.02.00
Are you sure you want to change the base?
DIS-231 Add notification to Koha exporter if offline mode is enabled #2202
Conversation
to test: * put aspen in offline mode: https://help.aspendiscovery.org/help/admin/SystemAdministration#Cell-1804-PanelBody * enter the adb shell and run the command aspen_koha_import * you should see a line in the output about the ILS being in offline mode * log into aspen and navigate to the ILS export log * the same note about the ILS being in offline mode should appear in the latest entry here as well.
3e040ee
to
6792ef1
Compare
@lathomas64 can you update release notes please. |
@mdnoble73 where would you like me to do that? I included a change to the 25.02.00.MD in this pull request is there somewhere else I should also update? |
In the release notes you currently have:
Instead make it
Also add your name and initials at the bottom. More information about how to update release notes is available here: https://dev.aspendiscovery.org/release-notes |
fixing release notes
forgot to hit save after adding my name to the contributor section
I am thinking after looking at the other exporters I want to pull this out into a common file instead actually so they can all call the same function. |
Moved the offline checks outside of KohaExporterMain so the code can be reused for other exporters
to test:
ticket link for convenience: https://aspen-discovery.atlassian.net/browse/DIS-231
added a log note that the exporter was quitting due to being in offline mode and a call to save the logEntry notes so they everything up to that point is actually saved in the log.