Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-231 Add notification to Koha exporter if offline mode is enabled #2202

Open
wants to merge 4 commits into
base: 25.02.00
Choose a base branch
from

Conversation

lathomas64
Copy link

to test:

ticket link for convenience: https://aspen-discovery.atlassian.net/browse/DIS-231

added a log note that the exporter was quitting due to being in offline mode and a call to save the logEntry notes so they everything up to that point is actually saved in the log.

to test:
* put aspen in offline mode: https://help.aspendiscovery.org/help/admin/SystemAdministration#Cell-1804-PanelBody
* enter the adb shell and run the command aspen_koha_import
* you should see a line in the output about the ILS being in offline mode
* log into aspen and navigate to the ILS export log
* the same note about the ILS being in offline mode should appear in the latest entry here as well.
@kylemhall kylemhall force-pushed the DIS-231-Add-Notification-Koha-Exporter-Offline-Mode branch from 3e040ee to 6792ef1 Compare January 17, 2025 11:56
@mdnoble73
Copy link
Member

@lathomas64 can you update release notes please.

@lathomas64
Copy link
Author

@mdnoble73 where would you like me to do that? I included a change to the 25.02.00.MD in this pull request is there somewhere else I should also update?

@mdnoble73
Copy link
Member

In the release notes you currently have:

//chloe
//imani
- added a note to KohaExportMain when it tries to run in offline Mode and attempt to save the log before exiting
### WebBuilder Updates
- Fixed an issue preventing administrators from saving a 'URL to link image to' from the 'WebBuilder Portal Cells' page. (*CZ*)

Instead make it

//imani
### Indexing Updates
- Added a note to KohaExportMain when it tries to run in offline Mode and attempt to save the log before exiting. (DIS-231) (*IT*)

//chloe
### WebBuilder Updates
- Fixed an issue preventing administrators from saving a 'URL to link image to' from the 'WebBuilder Portal Cells' page. (*CZ*)

Also add your name and initials at the bottom.
That will separate your work from Chloe's work and make merges easier.

More information about how to update release notes is available here: https://dev.aspendiscovery.org/release-notes

@lathomas64
Copy link
Author

I am thinking after looking at the other exporters I want to pull this out into a common file instead actually so they can all call the same function.

Moved the offline checks outside of KohaExporterMain so the code can be reused for other exporters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants